Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

SpanKind support in opencensus-java #1054

Closed
HailongWen opened this issue Mar 7, 2018 · 3 comments · Fixed by #1223
Closed

SpanKind support in opencensus-java #1054

HailongWen opened this issue Mar 7, 2018 · 3 comments · Fixed by #1223

Comments

@HailongWen
Copy link
Contributor

census-instrumentation/opencensus-proto#51 added SpanKind. We should add the initial support.

Another thread is discussing whether to add consumer/producer in the type census-instrumentation/opencensus-specs#54. This could be merged after the decision is made.

@bogdandrutu
Copy link
Contributor

I think we can add the SpanKind right now and extend later if needed, I would suggest that we update the docs related to HTTP/gRPC span names to not include "Sent." and "Recv." which we will be able to determine from the SpanKind.

Also we need to update the https://github.com/census-instrumentation/opencensus-java/blob/master/impl_core/src/main/java/io/opencensus/implcore/trace/export/InProcessSampledSpanStoreImpl.java to map not only by name but also by SpanKind.

@bogdandrutu
Copy link
Contributor

This is also related #1226

@voidzcy
Copy link

voidzcy commented Mar 25, 2020

gRPC is trying to migrate to use SpanKind (see grpc/grpc-java#6732), but since Span name is changed, this seems to be a "flip the switch" change for traffic monitoring pipelines. How should we migrate this in gRPC for OSS without breaking open-source users' traffic monitoring pipelines?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants