Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

census: add span kind and simplify span names #6732

Closed
wants to merge 1 commit into from

Conversation

gfelbing
Copy link
Contributor

@gfelbing gfelbing commented Feb 20, 2020

This PR sets the span kind on client/server spans and simplifies generation of span names.

@voidzcy reverted the initial approach of simply adding the kind due to internal opencensus implementation relying on the convention Span without kind needs to be in the format of "[Recv|Sent].Namespace.Service.Method" and Span with kind needs to be in the format of "Namespace.Service/Method"

As MethodDescriptor#getFullMethodName already returns the correct naming convention for spans with kind, the method generateTraceSpanName can be dropped when adding the span kind.

cc @creamsoup

@voidzcy voidzcy added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 21, 2020
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Feb 21, 2020
@voidzcy
Copy link
Contributor

voidzcy commented Feb 21, 2020

Thanks for polishing this.

@voidzcy
Copy link
Contributor

voidzcy commented Feb 21, 2020

We would not merge it now as we are unsure if this will break any internal monitoring tools. We will get back to you when we figured it out.

@creamsoup
Copy link
Contributor

this changes seems more desirable way. However, since the metric name is API, we can't change it unless we provide an migration plan. e.g. support both for a while to migrate.
I don't know how users use the metrics, but some monitoring / data collection can be broken after this change.
cc @zhangkun83 who has knowledge of census in general.

@ejona86
Copy link
Member

ejona86 commented Jun 15, 2023

At this point, OpenTelemetry design is making progress and we are able to change names there. We'll just leave OpenCensus the way it is; little benefit to touching it and making breaking something at thi spoint.

@ejona86 ejona86 closed this Jun 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants