census: add span kind and simplify span names #6732
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the span kind on client/server spans and simplifies generation of span names.
@voidzcy reverted the initial approach of simply adding the kind due to internal opencensus implementation relying on the convention Span without kind needs to be in the format of "[Recv|Sent].Namespace.Service.Method" and Span with kind needs to be in the format of "Namespace.Service/Method"
As MethodDescriptor#getFullMethodName already returns the correct naming convention for spans with kind, the method
generateTraceSpanName
can be dropped when adding the span kind.cc @creamsoup