Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

allow arbitrary metric prefixes #1440

Merged
merged 1 commit into from
Sep 17, 2018
Merged

allow arbitrary metric prefixes #1440

merged 1 commit into from
Sep 17, 2018

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 mentioned this pull request Sep 17, 2018
Closed
songy23
songy23 approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@songy23 songy23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a note in RELEASING.md, since this could be a breaking change.

EDIT: typo, should be CHANGELOG.md.

@songy23 songy23 added this to the Release 0.17.0 milestone Sep 17, 2018
@mayurkale22
Copy link
Member Author

@songy23 Done

@songy23
Copy link
Contributor

songy23 commented Sep 17, 2018

Please rebase and remove the merge commit (8b1d24d) from PR.

@mayurkale22 mayurkale22 merged commit 69360e9 into census-instrumentation:master Sep 17, 2018
@mayurkale22 mayurkale22 deleted the allow_arbitrary_metric_prefixes branch September 17, 2018 22:11
@sebright sebright mentioned this pull request Sep 18, 2018
Closed
sebright pushed a commit to sebright/opencensus-java that referenced this pull request Sep 18, 2018
@mayurkale22 @sebright
allow arbitrary metric prefixes (census-instrumentation#1440)
6233feb 
(cherry picked from commit 69360e9)
sebright added a commit that referenced this pull request Sep 18, 2018
@sebright
allow arbitrary metric prefixes (#1440)
4677f0a 
(cherry picked from commit 69360e9)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@songy23 songy23 songy23 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
Release 0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mayurkale22 @songy23 @googlebot