Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Clear handler reference on OcAgentTraceExporter unregister #1965

Merged

Conversation

c2nes
Copy link
Contributor

@c2nes c2nes commented Aug 23, 2019

This allows the exporter to be re-registered without triggering an IllegalStateException in createAndRegister.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase.

This allows the exporter to be re-registered without triggering an
IllegalStateException.
@c2nes c2nes force-pushed the oc-agent-exporter-clear-handler branch from 149c9cd to bdfa7c5 Compare August 24, 2019 15:47
@c2nes
Copy link
Contributor Author

c2nes commented Aug 24, 2019

@songy23 done

@songy23 songy23 merged commit a9f6695 into census-instrumentation:master Aug 26, 2019
@c2nes c2nes deleted the oc-agent-exporter-clear-handler branch August 27, 2019 13:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants