Conversation
Looks like deprecations have been made errors: Task :opencensus-contrib-appengine-standard-util:compileJava /home/travis/build/census-instrumentation/opencensus-java/contrib/appengine_standard_util/gen_gradle/src/main/java/io/opencensus/contrib/appengine/standard/util/TraceProto.java:37: warning: [deprecation] InternalDescriptorAssigner in FileDescriptor has been deprecated
/home/travis/build/census-instrumentation/opencensus-java/contrib/appengine_standard_util/gen_gradle/src/main/java/io/opencensus/contrib/appengine/standard/util/TraceProto.java:38: warning: [deprecation] InternalDescriptorAssigner in FileDescriptor has been deprecated
/home/travis/build/census-instrumentation/opencensus-java/contrib/appengine_standard_util/gen_gradle/src/main/java/io/opencensus/contrib/appengine/standard/util/TraceProto.java:46: warning: [deprecation] internalBuildGeneratedFileFrom(String[],FileDescriptor[],InternalDescriptorAssigner) in FileDescriptor has been deprecated
error: warnings found and -Werror specified |
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
============================================
- Coverage 83.09% 83.06% -0.03%
Complexity 2251 2251
============================================
Files 319 319
Lines 10529 10529
Branches 1048 1048
============================================
- Hits 8749 8746 -3
- Misses 1441 1446 +5
+ Partials 339 337 -2
Continue to review full report at Codecov.
|
@@ -161,7 +161,7 @@ subprojects { | |||
findBugsAnnotationsVersion = '3.0.1' | |||
findBugsJsr305Version = '3.0.2' | |||
errorProneVersion = '2.3.2' | |||
grpcVersion = '1.25.0' | |||
grpcVersion = '1.27.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgrading to grpcVersion will break grpc metrics collection using opencensus unless grpc-census package is included. See this release-note.
Please update the change.log for the dependency change and link to grpc release-note in the change.log.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@rghetia