-
Notifications
You must be signed in to change notification settings - Fork 97
Stats: apply restriction on TagKey and TagValue #268
Comments
hey i would like to help with this issue. In opencensus java it had a package called tag where different tagvalue & tagkey can be configured. Where should I look for it in this package? |
@vigneshtdev Thanks for your interest in the project, all contributions are welcomed and highly appreciated. Currently we dont have separate package for Tags api. I think we should create new one same as Java and Python. WDYT? |
I think that it is the correct way to go, as it will make implementation across all languages more consistent. However it would require major refactoring in both test & soruce |
Or else if such refactoring in unnecessary we can modify the existing invalidTags method. Currenlty it only check if the tagkey & tagvalue have printable characters. |
Fixed in #280. |
The TagKey name must meet the following requirements:
The TagValue name must meet the following requirements:
Specs: https://github.com/census-instrumentation/opencensus-specs/blob/master/tags/TagMap.md#tagkey
The text was updated successfully, but these errors were encountered: