This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
feat: add stats support to zpages exporter #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djonathascardoso
force-pushed
the
stats_zpages
branch
from
c17e1cc
to
f7e6ca9
Compare
djonathascardoso
force-pushed
the
stats_zpages
branch
from
f7e6ca9
to
a2bb8d7
Compare
kjin
reviewed
Aug 30, 2018
| // Fills the output columns for that method | ||
| if (view.name === DefaultViews.CLIENT_SENT_BYTES_PER_RPC || | ||
| view.name === DefaultViews.SERVER_SENT_BYTES_PER_RPC) { | ||
| const distribution = snapshot as DistributionData; |
There was a problem hiding this comment.
Can you throw an error if it's not a DistributionData, and remove this cast? (Also in below)
| @@ -65,21 +77,56 @@ export class ZpagesExporter implements Exporter { | |||
| } | |||
|
|
|||
| /** | |||
| * Is called whenever a span is started. | |||
| * It's called whenever a span is started. | |||
There was a problem hiding this comment.
Nit: Remove It's and just have it say: "Called whenver a span is started."
| assert.equal(bucket3.lowBoundary, 30); | ||
| assert.equal(bucket3.highBoundary, 40); | ||
|
|
||
| // 40...Infinity) |
kjin
approved these changes
Aug 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds stats support to zpages exporter. Unit tests are included.