This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
fix: remove const enums #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjin
reviewed
Oct 3, 2018
packages/opencensus-core/README.md
Outdated
| @@ -7,6 +7,8 @@ The library is in alpha stage and the API is subject to change. | |||
|
|
|||
| Please join [gitter](https://gitter.im/census-instrumentation/Lobby) for help or feedback on this project. | |||
|
|
|||
| _Note: If recompiling the library, the flag `strictNullChecks` should not be enabled._ | |||
There was a problem hiding this comment.
Do you need to make this note here?
eduardoemery
force-pushed
the
hotfix_enum
branch
from
9524033
to
48eb1b8
Compare
kjin
approved these changes
Oct 3, 2018
This was referenced Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following:
strictNullChecksenabled