Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix up typos in source #135

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Fix up typos in source #135

merged 1 commit into from
Nov 21, 2018

Conversation

xginn8
Copy link
Contributor

@xginn8 xginn8 commented Oct 5, 2018

No description provided.

@bogdandrutu
Copy link
Contributor

Please fix the build

@justindsmith
Copy link
Contributor

@xginn8 Looks like all you need to do is run npm run fix in the opencensus-exporter-prometheus package to fix the build.

Are you able to get this PR ready for submission? Looks straight-forward, so we can merge it quickly.

Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
@xginn8
Copy link
Contributor Author

xginn8 commented Nov 21, 2018

@justindsmith thanks for taking a look, I had forgotten about this PR. PTAL!

Copy link
Contributor

@justindsmith justindsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM :)

@justindsmith
Copy link
Contributor

@isaikevych Can you take a quick look. I think we can safely merge this now.

@songy23
Copy link
Contributor

songy23 commented Nov 21, 2018

@justindsmith Added you to the collaborator list of this repo, you should be able to merge PRs now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants