This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Adds metric name prefix override for [exporter-stackdriver] #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the build. |
|
Error log: src/stackdriver-monitoring.ts:72:52 - error TS2339: Property 'DELAY' does not exist on type 'typeof StackdriverStatsExporter'.
setTimeout(resolve, StackdriverStatsExporter.DELAY);Looks like this PR depends on #150. |
isaikevych
force-pushed
the
stackdriver_metric-name-prefix_override
branch
3 times, most recently
from
9dc866e
to
d1eaedb
Compare
kjin
reviewed
Oct 18, 2018
packages/opencensus-exporter-stackdriver/src/stackdriver-monitoring.ts
Outdated
Show resolved
Hide resolved
| @@ -42,6 +42,8 @@ export interface StackdriverExporterOptions extends ExporterConfig { | |||
| * projectId project id defined to stackdriver | |||
| */ | |||
| projectId: string; | |||
| /** Prefix for metric */ | |||
There was a problem hiding this comment.
Add a note on when the user might want to set this, and when they don't need to.
packages/opencensus-exporter-stackdriver/src/stackdriver-monitoring.ts
Outdated
Show resolved
Hide resolved
isaikevych
force-pushed
the
stackdriver_metric-name-prefix_override
branch
5 times, most recently
from
485763e
to
1307240
Compare
kjin
approved these changes
Oct 18, 2018
| /** | ||
| * Gets metric type | ||
| * @param name The view name | ||
| * @param prefix Optional metric prefix |
packages/opencensus-exporter-stackdriver/test/test-stackdriver-monitoring.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-exporter-stackdriver/test/test-stackdriver-monitoring.ts
Outdated
Show resolved
Hide resolved
isaikevych
force-pushed
the
stackdriver_metric-name-prefix_override
branch
3 times, most recently
from
be5cfb5
to
00f17cf
Compare
isaikevych
force-pushed
the
stackdriver_metric-name-prefix_override
branch
from
00f17cf
to
c83203a
Compare
|
Fixes #125 |
This was referenced Jan 24, 2020
This was referenced Jan 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All user-defined metric types have the DNS name custom.googleapis.com or
external.googleapis.com. Metric types should use a natural hierarchical grouping.
For example: ""custom.googleapis.com/invoice/paid/amount""
""external.googleapis.com/prometheus/up""
""appengine.googleapis.com/http/server/response_latencies"""