Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Conversation

conord33
Copy link
Contributor

I am not sure if this is the best place to change the spanId format. Another option would be to do it in the core/utils spanId generator, but I am not sure if other exporters or propagators expect the spanId to be in a certain format.

closes #161

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@conord33
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@isaikevych
Copy link
Contributor

Could you please add some test?

@conord33
Copy link
Contributor Author

Yeah will do

@conord33
Copy link
Contributor Author

Looks like this would also be fixed by upgrading to the V2 cloud trace api instead of using V1.

@conord33 conord33 force-pushed the exporter-stackdriver/fix-spanId-format branch 2 times, most recently from a0bd618 to 593bcc5 Compare October 26, 2018 13:05
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@conord33 conord33 force-pushed the exporter-stackdriver/fix-spanId-format branch from 593bcc5 to 54ccbf2 Compare October 26, 2018 13:18
@googlebot
Copy link

CLAs look good, thanks!

@conord33 conord33 force-pushed the exporter-stackdriver/fix-spanId-format branch from 54ccbf2 to b4dd0db Compare October 26, 2018 13:19
@conord33 conord33 force-pushed the exporter-stackdriver/fix-spanId-format branch from b4dd0db to 5c84d0c Compare October 26, 2018 13:32
@conord33
Copy link
Contributor Author

@isaikevych I updated the tests. Let me know what you think when you get a chance.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@isaikevych isaikevych force-pushed the exporter-stackdriver/fix-spanId-format branch from 33d189e to 5c84d0c Compare October 31, 2018 20:54
@googlebot
Copy link

CLAs look good, thanks!

@isaikevych isaikevych merged commit f1685dc into census-instrumentation:master Nov 5, 2018
@isaikevych
Copy link
Contributor

Thank you

@angelomichel
Copy link

Can we have a new release fixing the original issue (Invalid spanId error stackdriver-exporter, which seems to be resolved with this PR)?

We're running into the same issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid spanId error stackdriver-exporter
4 participants