-
Notifications
You must be signed in to change notification settings - Fork 97
fix spanId format #162
fix spanId format #162
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Could you please add some test? |
Yeah will do |
Looks like this would also be fixed by upgrading to the V2 cloud trace api instead of using V1. |
a0bd618
to
593bcc5
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
593bcc5
to
54ccbf2
Compare
CLAs look good, thanks! |
54ccbf2
to
b4dd0db
Compare
b4dd0db
to
5c84d0c
Compare
@isaikevych I updated the tests. Let me know what you think when you get a chance. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
33d189e
to
5c84d0c
Compare
CLAs look good, thanks! |
packages/opencensus-exporter-stackdriver/test/test-stackdriver-cloudtrace.ts
Outdated
Show resolved
Hide resolved
Thank you |
Can we have a new release fixing the original issue (Invalid spanId error stackdriver-exporter, which seems to be resolved with this PR)? We're running into the same issue. |
I am not sure if this is the best place to change the spanId format. Another option would be to do it in the core/utils spanId generator, but I am not sure if other exporters or propagators expect the spanId to be in a certain format.
closes #161