This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
instrumentation-http: Parse URL instead of relying on pathname #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentation-http rely on
options.pathname
for outgoing request to name the span. However, several libraries are passing options directly to http.request which save it as is.Affected libraries include:
To reproduce, simply setup a tracer and fire an outgoing request with request. The trace will have the name of
GET undefined
.This PR ensure that we parse every option for pathname instead of relying that it exists.