This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Fix malicious package, update nodemon -> 1.18.7 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Dec 3, 2018
| @@ -94,12 +96,14 @@ | |||
| "@types/mocha": { | |||
| "version": "2.2.48", | |||
| "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-2.2.48.tgz", | |||
| "integrity": "sha512-nlK/iyETgafGli8Zh9zJVCTicvU3iajSkRwOh3Hhiva598CMqNJ4NcVCGMTGKpGpTYj/9R8RLzS9NAykSSCqGw==" | |||
| "integrity": "sha512-nlK/iyETgafGli8Zh9zJVCTicvU3iajSkRwOh3Hhiva598CMqNJ4NcVCGMTGKpGpTYj/9R8RLzS9NAykSSCqGw==", | |||
| "dev": true | |||
There was a problem hiding this comment.
Why did you add dev: true everywhere?
There was a problem hiding this comment.
package-lock.json is automatically generated. If "dev": true then this dependency is either a development dependency ONLY of the top level module or a transitive dependency of one. (Source: https://docs.npmjs.com/files/package-lock.json#dev)
isaikevych
approved these changes
Dec 4, 2018
This was referenced Dec 4, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests failed on CircleCI ~5 days, because of an event-stream incident.
NPM blog on malicious package: https://blog.npmjs.org/post/180565383195/details-about-the-event-stream-incident.
nodemon@1.18.7: Completely removes the old method of
pstree[.remy]and drops the event-stream vulnerability at the same time.