Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Exporter/Stats/Prometheus: Sanitize metric names #217

Conversation

mayurkale22
Copy link
Member

No description provided.

Copy link
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@justindsmith justindsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but looks good overall!

CHANGELOG.md Outdated Show resolved Hide resolved
@mayurkale22 mayurkale22 force-pushed the prometheus_Sanitize_metric_names branch from f10ac6f to b6497e5 Compare December 4, 2018 19:33
@isaikevych isaikevych removed their request for review December 5, 2018 02:39
@mayurkale22 mayurkale22 force-pushed the prometheus_Sanitize_metric_names branch 2 times, most recently from 61fbef7 to 3aa3388 Compare December 7, 2018 17:27
@mayurkale22 mayurkale22 force-pushed the prometheus_Sanitize_metric_names branch from 3aa3388 to cc7d998 Compare December 7, 2018 17:32
@mayurkale22 mayurkale22 merged commit 7e22f53 into census-instrumentation:master Dec 7, 2018
@mayurkale22 mayurkale22 deleted the prometheus_Sanitize_metric_names branch December 7, 2018 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants