Stats: perform a deepcopy of bucketboundaries when performing measurements #222
Conversation
|
Although could you please update the title to |
Make sense, Done. |
mayurkale22
changed the title
mayurkale22
force-pushed
the
bug_fix
branch
2 times, most recently
from
693be7a
to
7d1feb7
Compare
There was a problem hiding this comment.
one small nit, but otherwise looks good!
one other nit, this technically isn't a deep copy, since Object.assign does a shallow copy. In this case it doesn't really matter because both of the arrays are flat number arrays, but just wanted to call it out so it's not confusing later on.
| view.recordMeasurement(measurement1); | ||
| } | ||
|
|
||
| it('should has points', () => { |
There was a problem hiding this comment.
nit: "should have points"
There was a problem hiding this comment.
Done. Corrected typos in other existing tests.
…ments While doing measurements, we were reusing bucket boundaries(counts and buckets) from pervious record instead of creating a new copy like other libraries do. Fixes census-instrumentation#221
I agreed, thanks for the explanation. |
While doing measurements, we were reusing bucket boundaries(counts and buckets)
from pervious record instead of creating a new copy like other libraries do.
Fixes #221