This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add start method to StatsEventListener #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current approach, we are calling onRegisterView (whenever a new view is registered) and onRecord (whenever a new measurement is recorded). With the new approach, plan is to start exporter that polls Metric from Metrics library and send batched data to backend.
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
- Coverage 94.61% 94.54% -0.07%
==========================================
Files 101 101
Lines 7311 7316 +5
Branches 690 690
==========================================
Hits 6917 6917
- Misses 394 399 +5
Continue to review full report at Codecov.
|
justindsmith
approved these changes
Jan 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current approach, we execute below apis for each request of new view and measurement.
onRegisterView- whenever a new view is registered andonRecord- whenever a new measurement is recorded.New approach: The plan is to start exporter that polls Metric from Metrics library (which is collection of metric from stats and gauges apis) and send batched data to backend.
Once the new approach is ready I will deprecate and remove
onRegisterViewandonRecordapis.