This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Simplify Logger interface, remove silly, make level optional #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draffensperger
requested review from
justindsmith,
OsvaldoRosado and
mayurkale22
mayurkale22
approved these changes
Jan 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=========================================
+ Coverage 94.8% 94.8% +<.01%
=========================================
Files 110 110
Lines 7779 7764 -15
Branches 713 713
=========================================
- Hits 7375 7361 -14
+ Misses 404 403 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
=========================================
+ Coverage 94.8% 94.8% +<.01%
=========================================
Files 110 110
Lines 7779 7764 -15
Branches 713 713
=========================================
- Hits 7375 7361 -14
+ Misses 404 403 -1
Continue to review full report at Codecov.
|
|
@mayurkale22 I added a note to the changlog, could you take another look and merge if all is good? |
OsvaldoRosado
approved these changes
Jan 10, 2019
mayurkale22
approved these changes
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing
sillyand making thelevelattribute optional (and defaulted todebug) then theconsoleinterface itself will implementLogger. See this TS playgroundThis will be useful for
opencensus-webwhere a major goal is small code size for web clients, so being able to just useconsoleitself as a logger cuts down on code size.This does seem like a relatively minor breaking change though.