This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Set startTimestamp to creation time of cumulative view #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
justindsmith,
draffensperger,
OsvaldoRosado and
songy23
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 94.8% 94.81% +<.01%
==========================================
Files 110 110
Lines 7779 7786 +7
Branches 713 713
==========================================
+ Hits 7375 7382 +7
Misses 404 404
Continue to review full report at Codecov.
|
|
Same as #272, we need to change 'View' startTime to use high resolutions timestamp ( ). I think this is breaking change and I prefer to do in separate PR. |
draffensperger
approved these changes
Jan 10, 2019
| @@ -200,9 +200,10 @@ export class BaseView implements View { | |||
|
|
|||
| /** | |||
| * Gets view`s metric | |||
| * @param start The start timestamp | |||
There was a problem hiding this comment.
Should this say add "in epoch milliseconds"?
songy23
approved these changes
Jan 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.