This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Minor changes to Stackdriver example #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
reviewed
Jan 17, 2019
examples/stats/exporter/README.md
Outdated
|
|
||
| You can observe the Prometheus Metrics Exporter that is created by the sample: | ||
| ``` | ||
| http://localhost:9465/metrics |
There was a problem hiding this comment.
s/9465/9464, we have mentioned 9464 port in example.
| * metrics that must be collected, or some risk being lost if they are recorded | ||
| * after the last export. | ||
| */ | ||
| setTimeout(function() { |
There was a problem hiding this comment.
I think we should remove this block. This is not applicable for Prometheus exporter.
examples/stats/exporter/README.md
Outdated
|
|
||
| ### Run it | ||
|
|
||
| ``` |
There was a problem hiding this comment.
Do you think we should install cmd here?
npm install @opencensus/core
npm install @opencensus/exporter-stackdriver
There was a problem hiding this comment.
Fixed by adding a general package.json and instructions: 713b4d2
Added Dockerfiles and instructions too.
mayurkale22
approved these changes
Jan 17, 2019
|
@DazWilkin thanks for the PR. Somehow build is failing since last 2 days on node6. Update: Build failure is not related to this PR. Feel free to merge. |
mayurkale22
reviewed
Jan 17, 2019
examples/stats/exporter/package.json
Outdated
| "access": "public" | ||
| }, | ||
| "devDependencies": { | ||
| "jshint": "^2.9.7" |
There was a problem hiding this comment.
Can we use gts here? This is what we use everywhere..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stackdriver example
Two changes (one needs to be fixed):
-- tagKeys used when creating the view ought match those used when recording stats. The code now creates tagKeys of
["method", "status"];-- views should be created and then registered but this appears to not be required with this implementation. The code now creates the views without assigning these to unused constants. If the library is amended to require the
createView(X)followed byregisteredView(X), then these constants may be reverted. Or the resultcreateViewmay be applied directly tostats.registerView(stats.createView(...).Prometheus example
Added: mirrors the Stackdriver example. Works but there's likely room for improvement as it is not dependent on the 60-second timeout etc.
README
Added a REAMDE for the examples because there should be one ;-)
It remains unclear to me how to run these examples after cloning. I had to:
package.jsonto spec the@opencensusdependencies but assume there's a better way to do this../test.txtto get this to work.Please add an explanation to the README on how to run the examples directly from a clone.