New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes http.get patches for header propagation #117 #324

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@vmarchaud
Copy link

vmarchaud commented Feb 3, 2019

I got the same issue as #117 while integrating the tracing system into my APM.
I did go over https://github.com/googleapis/cloud-trace-nodejs/ to checkout their implementation and found a details that could explain the problem: https://github.com/googleapis/cloud-trace-nodejs/blob/master/src/plugins/plugin-http.ts#L198

The test are passing for one good reason: they are all nocked, so the actual http code never run. I added a test that make a GET request to google.fr, it might be better to spawn a local server to avoid instability due to network.

@googlebot googlebot added the cla: yes label Feb 3, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #324 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   94.93%   94.99%   +0.06%     
==========================================
  Files         119      119              
  Lines        8172     8195      +23     
  Branches      732      734       +2     
==========================================
+ Hits         7758     7785      +27     
+ Misses        414      410       -4
Impacted Files Coverage Δ
test/test-http.ts 98.44% <0%> (-0.99%) ⬇️
src/http.ts 91.5% <0%> (+1.7%) ⬆️
src/stackdriver-monitoring.ts 84.21% <0%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10212f...e5ca654. Read the comment docs.

@vmarchaud

This comment has been minimized.

Copy link
Author

vmarchaud commented Feb 3, 2019

Not related but i believe the problem is the same with https.get, might need another PR

@vmarchaud

This comment has been minimized.

Copy link
Author

vmarchaud commented Feb 17, 2019

@draffensperger @mayurkale22 Sorry for the ping but do the PR need something specific to be reviewed and merged ?
I wanted to contribute to the node implementation since i'm using it for my APM but the time it take to make a change merged is quite long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment