This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
fixes http.get patches for header propagation #117 #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the same issue as #117 while integrating the tracing system into my APM.
I did go over https://github.com/googleapis/cloud-trace-nodejs/ to checkout their implementation and found a details that could explain the problem: https://github.com/googleapis/cloud-trace-nodejs/blob/master/src/plugins/plugin-http.ts#L198
The test are passing for one good reason: they are all
nocked
, so the actual http code never run. I added a test that make a GET request togoogle.fr
, it might be better to spawn a local server to avoid instability due to network.