Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Update dependency gcp-metadata to v1 #346

Merged
merged 2 commits into from
Mar 16, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 16, 2019

This PR contains the following updates:

Package Type Update Change References
gcp-metadata dependencies major ^0.9.3 -> ^1.0.0 source

Release Notes

googleapis/gcp-metadata

v1.0.0

Compare Source

02-14-2019 16:00 PST

Bug Fixes
  • fix: ask gaxios for text and not json (#​152)
Documentation
  • docs: update links in contrib guide (#​168)
  • docs: add lint/fix example to contributing guide (#​160)
Internal / Testing Changes
  • build: use linkinator for docs test (#​166)
  • chore(deps): update dependency @​types/tmp to v0.0.34 (#​167)
  • build: create docs test npm scripts (#​165)
  • test: run system tests on GCB (#​157)
  • build: test using @​grpc/grpc-js in CI (#​164)
  • chore: move CONTRIBUTING.md to root (#​162)
  • chore(deps): update dependency gcx to v0.1.1 (#​159)
  • chore(deps): update dependency gcx to v0.1.0 (#​158)
  • chore(deps): update dependency gcx to v0.0.4 (#​155)
  • chore(deps): update dependency googleapis to v37 (#​156)
  • build: ignore googleapis.com in doc link check (#​153)
  • build: check broken links in generated docs (#​149)
  • chore(build): inject yoshi automation key (#​148)

Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

@renovate renovate bot force-pushed the renovate/gcp-metadata-1.x branch 6 times, most recently from 4d6b113 to b91ed61 Compare February 22, 2019 03:23
@renovate renovate bot force-pushed the renovate/gcp-metadata-1.x branch 17 times, most recently from 650e43a to 6a0fbfb Compare March 3, 2019 20:45
@renovate renovate bot force-pushed the renovate/gcp-metadata-1.x branch 4 times, most recently from f6c20a6 to 9322243 Compare March 7, 2019 02:54
@renovate renovate bot changed the title fix(deps): update dependency gcp-metadata to v1 Update dependency gcp-metadata to v1 Mar 7, 2019
@renovate renovate bot force-pushed the renovate/gcp-metadata-1.x branch 5 times, most recently from 0524145 to c239233 Compare March 11, 2019 18:00
@renovate renovate bot force-pushed the renovate/gcp-metadata-1.x branch 8 times, most recently from 5161d32 to 3b28a7f Compare March 15, 2019 17:29
@renovate renovate bot force-pushed the renovate/gcp-metadata-1.x branch from 3b28a7f to e789e46 Compare March 15, 2019 21:03
@renovate
Copy link
Contributor Author

renovate bot commented Mar 15, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

codecov-io commented Mar 15, 2019

Codecov Report

Merging #346 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   94.88%   94.91%   +0.02%     
==========================================
  Files         140      140              
  Lines        9293     9294       +1     
  Branches      671      671              
==========================================
+ Hits         8818     8821       +3     
+ Misses        475      473       -2
Impacted Files Coverage Δ
test/nocks.ts 62.71% <0%> (+0.64%) ⬆️
src/stackdriver-monitoring.ts 82.29% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b80a65...213e07c. Read the comment docs.

@mayurkale22
Copy link
Member

Fixed the build, tests got impacted because of googleapis/gcp-metadata#117

@draffensperger @justindsmith can you please review and approve.

@mayurkale22 mayurkale22 added this to the Release 0.0.10 milestone Mar 15, 2019
@mayurkale22 mayurkale22 merged commit 1dae581 into master Mar 16, 2019
@renovate renovate bot deleted the renovate/gcp-metadata-1.x branch March 16, 2019 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants