Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add option of passing in an object(SpanOptions) to the startChildSpan #349

Conversation

mayurkale22
Copy link
Member

This will make things consistent with startRootSpan function. Currently, startChildSpan function takes three arguments instead of an object.

To avoid breaking changes, I have introduced three favors of startChildSpan overloaded function.

@mayurkale22 mayurkale22 changed the title add option of passing in an object to the createChildSpan Add option of passing in an object to the startChildSpan Feb 19, 2019
@mayurkale22 mayurkale22 changed the title Add option of passing in an object to the startChildSpan add option of passing in an object(SpanOptions) to the createChildSpan Feb 19, 2019
@mayurkale22 mayurkale22 changed the title add option of passing in an object(SpanOptions) to the createChildSpan Add option of passing in an object(SpanOptions) to the startChildSpan Feb 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #349 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   95.28%   95.27%   -0.02%     
==========================================
  Files         124      124              
  Lines        8339     8361      +22     
  Branches      619      619              
==========================================
+ Hits         7946     7966      +20     
- Misses        393      395       +2
Impacted Files Coverage Δ
src/stackdriver-monitoring.ts 81.05% <0%> (-2.11%) ⬇️
test/test-root-span.ts 100% <0%> (ø) ⬆️
test/test-tracer.ts 100% <0%> (ø) ⬆️
src/trace/model/tracer.ts 84.26% <0%> (ø) ⬆️
test/test-instana.ts 100% <0%> (ø) ⬆️
src/trace/model/root-span.ts 100% <0%> (ø) ⬆️
src/trace/model/types.ts 100% <0%> (ø) ⬆️
test/test-zipkin.ts 100% <0%> (ø) ⬆️
src/mongodb.ts 92.75% <0%> (ø) ⬆️
test/test-zpages.ts 99.62% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5f4d1...7721202. Read the comment docs.

@mayurkale22
Copy link
Member Author

@draffensperger Thanks for the reviews

@mayurkale22 mayurkale22 merged commit 2c56a2a into census-instrumentation:master Feb 21, 2019
@mayurkale22 mayurkale22 deleted the startChildSpan_with_object branch February 21, 2019 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants