-
Notifications
You must be signed in to change notification settings - Fork 97
Fix mongodb instrumentation not ending span correctly #358
Fix mongodb instrumentation not ending span correctly #358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
=========================================
- Coverage 95.23% 95.2% -0.04%
=========================================
Files 129 129
Lines 8592 8598 +6
Branches 634 638 +4
=========================================
+ Hits 8183 8186 +3
- Misses 409 412 +3
Continue to review full report at Codecov.
|
Test failures are related to Stackdriver so i believe we can ignore them for this PR |
I am working on fixing the build. |
Can you please rebase your branch with the master, hopefully it will fix build. |
I believe the PR can be merged now ? |
Ping @mayurkale22 |
@vmarchaud Thanks for the contributions, PR looks good. If no other comments from @draffensperger I will merge this PR later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fixes and comments.
From my tests all the mongodb queries had the wrong duration so i inspected the code and found out that the span were never ended and automatically truncated when the root span is ended.
So i rewrote a little bit the patchs so they could correctly be ended and added the verification in the tests
cc @draffensperger @mayurkale22