Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix stackdriver test #363

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

mayurkale22
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #363 into master will decrease coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #363     +/-   ##
========================================
- Coverage      96%   95.3%   -0.7%     
========================================
  Files          79     124     +45     
  Lines        4850    8413   +3563     
  Branches      263     624    +361     
========================================
+ Hits         4656    8018   +3362     
- Misses        194     395    +201
Impacted Files Coverage Δ
src/index.ts 100% <0%> (ø) ⬆️
test/test-b3-format.ts 100% <0%> (ø) ⬆️
src/stackdriver-cloudtrace.ts 92.53% <0%> (ø)
test/test-ocagent.ts 91.74% <0%> (ø)
test/nocks.ts 62.06% <0%> (ø)
src/zpages-frontend/routes.ts 100% <0%> (ø)
src/common-utils.ts 100% <0%> (ø)
src/validators.ts 100% <0%> (ø)
test/test-detect-resource.ts 100% <0%> (ø)
test/test-grpc.ts 99.64% <0%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0267db1...e7c8ef9. Read the comment docs.

@draffensperger
Copy link
Contributor

Do we know why this broke?

@mayurkale22
Copy link
Member Author

Looks like some internal auth library changed/updated, didn't spend long time in investigation. I hope that's ok. :)

@draffensperger
Copy link
Contributor

Ah, I see. Maybe as a follow-up, should that test be checking for a 403 response code rather than a string in the response?

@mayurkale22
Copy link
Member Author

Ah, I see. Maybe as a follow-up, should that test be checking for a 403 response code rather than a string in the response?

Added check for response code. It's actually 401 (Unauthorized). :)

@mayurkale22 mayurkale22 merged commit 8572750 into census-instrumentation:master Feb 26, 2019
@mayurkale22 mayurkale22 deleted the fix_tests branch February 26, 2019 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants