This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
enforce strictNullChecks on HTTP plugin #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
commented
Feb 26, 2019
| @@ -8,7 +8,8 @@ | |||
| "pretty": true, | |||
| "module": "commonjs", | |||
| "target": "es6", | |||
| "strictNullChecks": false | |||
| "strictNullChecks": true, | |||
| "noUnusedLocals": false | |||
There was a problem hiding this comment.
Will enable noUnusedLocals once stats are recorded for http plugin.
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 95.34% 95.34% +<.01%
==========================================
Files 124 124
Lines 8413 8423 +10
Branches 624 637 +13
==========================================
+ Hits 8021 8031 +10
Misses 392 392
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Feb 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #348