Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

enforce strictNullChecks on HTTP plugin #364

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Feb 26, 2019

This is part of #348

@@ -8,7 +8,8 @@
"pretty": true,
"module": "commonjs",
"target": "es6",
"strictNullChecks": false
"strictNullChecks": true,
"noUnusedLocals": false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will enable noUnusedLocals once stats are recorded for http plugin.

@codecov-io
Copy link

Codecov Report

Merging #364 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
+ Coverage   95.34%   95.34%   +<.01%     
==========================================
  Files         124      124              
  Lines        8413     8423      +10     
  Branches      624      637      +13     
==========================================
+ Hits         8021     8031      +10     
  Misses        392      392
Impacted Files Coverage Δ
test/test-http.ts 98.46% <0%> (ø) ⬆️
src/http.ts 91.42% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba7367...ce9079f. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for fixing this.

@mayurkale22 mayurkale22 merged commit d4f36b0 into census-instrumentation:master Feb 26, 2019
@mayurkale22 mayurkale22 deleted the http_plugin_strictNullChecks branch February 26, 2019 21:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants