-
Notifications
You must be signed in to change notification settings - Fork 97
Fix the exporter-ocagent #366
Fix the exporter-ocagent #366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be an issue to track adding the ConfigStream behavior back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If possible, please include exporter-ocagent
example in examples folder?
I took a quick look and didn't see any tracing specific examples. I don't think having an exporter specific example is useful without the larger tracing context, so I'm going to hold off on adding an example, but I'll add a tracking issue to add a tracing-specific example, as I think that would be useful. |
The
exporter-ocagent
had two critical issues which left the exporter unusable:ConfigStream
behavior (where the ocagent can send configuration changes down to the client) was not connecting / receiving correctly from the ocagent, causing errors and spamming logsThe following changes have been applied to fix the above issues:
@opencensus/exporter-ocagent
package. The changes mostly reside in thepackage.json
configuration.ConfigStream
behavior. This is a breaking change, but the ocagent exporter was not in a usable form previously, so I don't expect there to be any users directly impacted.A few other changes have been included as well:
55678
to match the default OC Agent/Collector port.grpc
dependency version to1.18.0
.These changes have all been tested locally against a real local ocagent instance and been confirmed to be working.