Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

chore: add node 11 ci job #375

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

mayurkale22
Copy link
Member

I am optimistic about tests and build, Let's see how much work required to add support for node 11.

image

@codecov-io
Copy link

Codecov Report

Merging #375 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #375   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files         128      128           
  Lines        8492     8492           
  Branches      628      628           
=======================================
  Hits         8084     8084           
  Misses        408      408
Impacted Files Coverage Δ
test/test-grpc.ts 99.68% <0%> (ø) ⬆️
src/grpc.ts 93.69% <0%> (ø) ⬆️
src/grpc-stats/server-stats.ts
src/grpc-stats/client-stats.ts
src/grpc-stats/server-metrics.ts 100% <0%> (ø)
src/grpc-stats/client-metrics.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0de66...0956770. Read the comment docs.

@mayurkale22
Copy link
Member Author

@draffensperger Looks like node 11 is good to go. Should we include in the ci job?

@draffensperger
Copy link
Contributor

Yes, sounds good!

@mayurkale22 mayurkale22 merged commit 1bb958a into census-instrumentation:master Mar 1, 2019
@mayurkale22 mayurkale22 deleted the node-11 branch March 1, 2019 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants