Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Propagation/TraceContext: Enforce strictNullChecks and noUnusedLocals #377

Conversation

mayurkale22
Copy link
Member

This is part of #348

@codecov-io
Copy link

Codecov Report

Merging #377 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   95.22%   95.21%   -0.01%     
==========================================
  Files         128      128              
  Lines        8487     8471      -16     
  Branches      627      629       +2     
==========================================
- Hits         8082     8066      -16     
  Misses        405      405
Impacted Files Coverage Δ
src/tracecontext-format.ts 97.82% <0%> (-2.18%) ⬇️
test/test-tracecontext-format.ts 98.96% <0%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a887a57...cd17f55. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mayurkale22 mayurkale22 changed the title Enforce strictNullChecks and noUnusedLocals on propagation-tracecontext Propagation/TraceContext: Enforce strictNullChecks and noUnusedLocals Mar 5, 2019
@mayurkale22 mayurkale22 merged commit fa97a9b into census-instrumentation:master Mar 7, 2019
@mayurkale22 mayurkale22 deleted the tracecontext_strictNullcheck branch March 7, 2019 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants