Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Exporter/jaeger: Enforce strictNullChecks and noUnusedLocals #382

Merged
merged 2 commits into from
Mar 8, 2019

Conversation

mayurkale22
Copy link
Member

This is part of #348

@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #382 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   94.81%   94.77%   -0.04%     
==========================================
  Files         136      136              
  Lines        8941     8942       +1     
  Branches      648      650       +2     
==========================================
- Hits         8477     8475       -2     
- Misses        464      467       +3
Impacted Files Coverage Δ
src/stackdriver-monitoring.ts 81.05% <0%> (-3.16%) ⬇️
src/jaeger-driver/index.ts 97.22% <0%> (-0.08%) ⬇️
test/test-jaeger.ts 99.21% <0%> (ø) ⬆️
src/jaeger.ts 83.51% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ec183...5e1c89a. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mayurkale22 mayurkale22 merged commit 73f83a1 into census-instrumentation:master Mar 8, 2019
@mayurkale22 mayurkale22 deleted the jaeger_fix branch March 8, 2019 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants