This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Instrumentation/HTTP2/HTTPS: Enforce strictNullChecks and noUnusedLocals #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draffensperger
approved these changes
Mar 8, 2019
| const path = requestHeaders[':path']; | ||
| let statusCode = 200; | ||
| if (path) { | ||
| statusCode = path.length > 1 ? +path.slice(1) : 200; |
There was a problem hiding this comment.
Nit: what would you think about using Number(path.slice(1)) to make the type conversion a bit more explicit?
And do we need to worry about malformed numbers here (that would give NaN to the Number constructor call)? If so, I'd say we can do in a follow up PR, but figured I'd mention as I'm thinking of it here.
There was a problem hiding this comment.
Good call, added isNaN check. PTAL
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
==========================================
- Coverage 94.82% 94.77% -0.06%
==========================================
Files 136 136
Lines 8935 8942 +7
Branches 656 662 +6
==========================================
+ Hits 8473 8475 +2
- Misses 462 467 +5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strictNullCheckswill help us to make the code safer (referencing nulls or undefined values), more robust and reduce some boilerplate.This is part of #348