Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

add ioredis instrumentation plugin #410

Merged
merged 1 commit into from
Mar 14, 2019
Merged

add ioredis instrumentation plugin #410

merged 1 commit into from
Mar 14, 2019

Conversation

vmarchaud
Copy link
Contributor

@vmarchaud vmarchaud commented Mar 10, 2019

@codecov-io
Copy link

codecov-io commented Mar 10, 2019

Codecov Report

Merging #410 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #410      +/-   ##
=========================================
- Coverage   94.81%   94.8%   -0.01%     
=========================================
  Files         136     138       +2     
  Lines        9000    9086      +86     
  Branches      666     667       +1     
=========================================
+ Hits         8533    8614      +81     
- Misses        467     472       +5
Impacted Files Coverage Δ
src/prometheus-stats.ts 92.78% <0%> (-1.1%) ⬇️
src/stats/view.ts 97.43% <0%> (-0.24%) ⬇️
test/test-view.ts 98.17% <0%> (-0.21%) ⬇️
src/stats/recorder.ts 97.56% <0%> (-0.06%) ⬇️
src/stackdriver-cloudtrace-utils.ts 97.26% <0%> (-0.04%) ⬇️
src/stats/types.ts 100% <0%> (ø) ⬆️
src/http.ts 91.21% <0%> (ø) ⬆️
test/test-recorder.ts 100% <0%> (ø) ⬆️
test/test-prometheus-stats.ts 100% <0%> (ø) ⬆️
src/mongodb.ts 91.78% <0%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3111ab8...b2b9a13. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and for use of strong types where possible!

@vmarchaud
Copy link
Contributor Author

I believe i've addressed every issue

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include Redis and IORedis in supported list of plugins -> https://github.com/census-instrumentation/opencensus-node#plugins

packages/opencensus-instrumentation-ioredis/src/ioredis.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,17 @@
# OpenCensus ioredis Instrumentation for Node.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional : s/ioredis/IORedis?

@vmarchaud
Copy link
Contributor Author

@mayurkale22 Are you sure to add them in the global readme even though they are not currently enabled with the latest version ? We would need a separate PR to add them into instrumentation-all package so i believe this change should be done in the separate PR

@mayurkale22
Copy link
Member

@mayurkale22 Are you sure to add them in the global readme even though they are not currently enabled with the latest version ? We would need a separate PR to add them into instrumentation-all package so i believe this change should be done in the separate PR

Makes sense 👍

@mayurkale22 mayurkale22 added this to the Release 0.0.10 milestone Mar 14, 2019
@mayurkale22
Copy link
Member

Thanks for the contribution again!

@mayurkale22 mayurkale22 merged commit fa110c4 into census-instrumentation:master Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants