-
Notifications
You must be signed in to change notification settings - Fork 97
add ioredis instrumentation plugin #410
add ioredis instrumentation plugin #410
Conversation
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
=========================================
- Coverage 94.81% 94.8% -0.01%
=========================================
Files 136 138 +2
Lines 9000 9086 +86
Branches 666 667 +1
=========================================
+ Hits 8533 8614 +81
- Misses 467 472 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and for use of strong types where possible!
packages/opencensus-instrumentation-ioredis/test/test-ioredis.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-instrumentation-ioredis/test/test-ioredis.ts
Outdated
Show resolved
Hide resolved
packages/opencensus-instrumentation-ioredis/test/test-ioredis.ts
Outdated
Show resolved
Hide resolved
I believe i've addressed every issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include Redis and IORedis in supported list of plugins -> https://github.com/census-instrumentation/opencensus-node#plugins
@@ -0,0 +1,17 @@ | |||
# OpenCensus ioredis Instrumentation for Node.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional : s/ioredis/IORedis?
packages/opencensus-instrumentation-ioredis/test/test-ioredis.ts
Outdated
Show resolved
Hide resolved
@mayurkale22 Are you sure to add them in the global readme even though they are not currently enabled with the latest version ? We would need a separate PR to add them into |
Makes sense 👍 |
Thanks for the contribution again! |
cc @mayurkale22 @draffensperger