This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Tags: Add support for TagMetadata #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
mayurkale22
force-pushed
the
tag-metadata
branch
from
6bbd58b
to
4eab6b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 94.88% 94.94% +0.05%
==========================================
Files 140 141 +1
Lines 9293 9333 +40
Branches 671 672 +1
==========================================
+ Hits 8818 8861 +43
+ Misses 475 472 -3
Continue to review full report at Codecov.
|
songy23
reviewed
Mar 14, 2019
| @@ -25,3 +25,38 @@ export interface TagValue { | |||
| /** The value of a tag. */ | |||
| readonly value: string; | |||
| } | |||
|
|
|||
| /** TagValueWithMetadata holds a TagValue and a TagMetadata. */ | |||
| export interface TagValueWithMetadata { | |||
There was a problem hiding this comment.
If possible please don't expose this in the public APIs. In Java it's used as an internal implementation class (not part of API).
There was a problem hiding this comment.
Done, now this interface is limited to core package only.
draffensperger
approved these changes
Mar 14, 2019
mayurkale22
force-pushed
the
tag-metadata
branch
from
fe3e5d8
to
a511512
Compare
songy23
approved these changes
Mar 14, 2019
mayurkale22
force-pushed
the
tag-metadata
branch
2 times, most recently
from
58d629b
to
d2c41b0
Compare
draffensperger
approved these changes
Mar 14, 2019
mayurkale22
force-pushed
the
tag-metadata
branch
from
d2c41b0
to
beec862
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specs: https://github.com/census-instrumentation/opencensus-specs/blob/master/tags/TagMap.md#tagmetadata
This PR contains support for recording
TagMetadata, there will be another PR after #326 to enforce check on propagating tags at Receiver and Sender level (https://github.com/census-instrumentation/opencensus-specs/blob/master/tags/TagMap.md#processing-at-receiver-and-sender).Fixes #296