This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
refactor: remove ZpagesExporter#getAllTraces #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djonathascardoso
approved these changes
Jun 15, 2018
kjin
added a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
kjin
added a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
kjin
added a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
getAllTracesfrom the public UI ofZpagesExporter. It was used in two places:ZpagesExporterandTracezPageHandlerclasses instead share a reference to the map of all traces.json=1query flag that reports the JSON object that contains the information used when rendering the main page.ZpagesExporter#getAllTraces.To be able to report JSON information, we need to serialize traces. However, there is no common way to do so, because
SpanBaseobjects in the core module are not serializable (they contain circular references). For that reason I have added a TODO to make it serializable, and in the meantime have patched together a function that partially clones a span object (serializable properties only).