Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

opencensus-zpages: Enforce strictNullChecks and noUnusedLocals #432

Conversation

mayurkale22
Copy link
Member

This is part of #348. 3 more packages to go, 19 done so far.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-io
Copy link

Codecov Report

Merging #432 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #432      +/-   ##
=========================================
- Coverage   94.94%   94.9%   -0.04%     
=========================================
  Files         141     141              
  Lines        9334    9321      -13     
  Branches      672     673       +1     
=========================================
- Hits         8862    8846      -16     
- Misses        472     475       +3
Impacted Files Coverage Δ
src/stackdriver-monitoring.ts 80.2% <0%> (-3.13%) ⬇️
...rontend/page-handlers/traceconfigz.page-handler.ts 70.83% <0%> (ø) ⬆️
...zpages-frontend/page-handlers/rpcz.page-handler.ts 100% <0%> (ø) ⬆️
test/test-zpages.ts 99.62% <0%> (ø) ⬆️
src/zpages.ts 87.93% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d838da0...b2efd48. Read the comment docs.

@mayurkale22 mayurkale22 merged commit 234c395 into census-instrumentation:master Mar 20, 2019
@mayurkale22 mayurkale22 deleted the enforce_strictNullcheck_zpages branch March 20, 2019 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants