This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Make Stackdriver propagation module consistent with other propagations interface #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
packages/opencensus-propagation-stackdriver/test/test-stackdriver-format.ts
Outdated
Show resolved
Hide resolved
draffensperger
approved these changes
Mar 20, 2019
packages/opencensus-propagation-stackdriver/src/stackdriver-format.ts
Outdated
Show resolved
Hide resolved
mayurkale22
force-pushed
the
enforce_strictNullcheck_sd_prop
branch
from
6a8c839
to
7792f2b
Compare
draffensperger
approved these changes
Mar 20, 2019
kjin
approved these changes
Mar 21, 2019
1. Use replace instead of split-join 2. Add helperGetter function
mayurkale22
force-pushed
the
enforce_strictNullcheck_sd_prop
branch
from
438cbfe
to
0417b49
Compare
Sure, btw current build failure wasn't related to this change. |
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
==========================================
+ Coverage 94.9% 94.97% +0.06%
==========================================
Files 141 143 +2
Lines 9321 9407 +86
Branches 673 678 +5
==========================================
+ Hits 8846 8934 +88
+ Misses 475 473 -2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
B3,Binary Format,TraceContextandJaegerpropagation exports a class constructor. Fixes B3 Propagation UX issues #340strictNullChecksandnoUnusedLocalson Stackdriver propagation package. This is part of feat: enable strictNullChecks on this repo. #348