Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Remove deprecated @types/pkg-dir and pkg-dir #438

Merged

Conversation

mayurkale22
Copy link
Member

The @types/pkg-dir package has been deprecated. https://www.npmjs.com/package/@types/pkg-dir

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #438 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage   94.88%   94.9%   +0.02%     
=========================================
  Files         141     141              
  Lines        9321    9321              
  Branches      673     673              
=========================================
+ Hits         8844    8846       +2     
+ Misses        477     475       -2
Impacted Files Coverage Δ
...ages-frontend/page-handlers/statsz.page-handler.ts 83.33% <0%> (ø) ⬆️
...zpages-frontend/page-handlers/rpcz.page-handler.ts 100% <0%> (ø) ⬆️
test/test-http2.ts 99.33% <0%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234c395...9c98265. Read the comment docs.

@mayurkale22 mayurkale22 changed the title Remove deprecated @types/pkg-dir and update pkg-dir to v4 Remove deprecated @types/pkg-dir and pkg-dir Mar 21, 2019
@mayurkale22
Copy link
Member Author

@draffensperger I have removed dependency on pkg-dir package also, as it is not supported for node 6 -> https://github.com/sindresorhus/pkg-dir/blob/master/package.json#L13

Once you have time, please take a look again. Thanks.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to prune one dependency!

@mayurkale22 mayurkale22 merged commit 9c95aa0 into census-instrumentation:master Mar 21, 2019
@mayurkale22 mayurkale22 deleted the deprecated_pkg-dir_types branch March 21, 2019 00:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants