-
Notifications
You must be signed in to change notification settings - Fork 97
Add support for gRPC tags propagation #443
Add support for gRPC tags propagation #443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #443 +/- ##
=========================================
+ Coverage 95.02% 95.1% +0.07%
=========================================
Files 149 149
Lines 9655 9760 +105
Branches 683 690 +7
=========================================
+ Hits 9175 9282 +107
+ Misses 480 478 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! It looks like the grpc-tags-bin
header is only being serialized/deserialized in the getTagContext
/setTagContext
helper functions. Are those called automatically when gRPC calls happen? (Or will that be in a follow-up CL?)
ac0e918
to
9b62e2b
Compare
I have added hook to use these functions during gRPC incoming request and outgoing request . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, nice that the gRPC plugins now support tags with those new changes.
Fixes #325
This PR contains the following changes
contextManager
across tracer and stats singleton instances.withTagContext
andgetCurrentTagContext
API on stats, so that plugins can use these API to get currentTagContext/TagMap
.TagMap
during get/set intocontextManager
.grpc-tags-bin
header with serializedTagMap
.tag-context-example.js
example.