This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Fix docs #457
Merged
Fix docs #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
draffensperger and
justindsmith
as code owners
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 94.27% 94.66% +0.39%
==========================================
Files 150 150
Lines 8782 9649 +867
Branches 711 726 +15
==========================================
+ Hits 8279 9134 +855
- Misses 503 515 +12
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
=========================================
+ Coverage 94.27% 94.67% +0.4%
=========================================
Files 150 150
Lines 8782 9724 +942
Branches 711 726 +15
=========================================
+ Hits 8279 9206 +927
- Misses 503 518 +15
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Apr 1, 2019
| import {BucketBoundaries} from './bucket-boundaries'; | ||
| import {MetricUtils} from './metric-utils'; | ||
| import {Recorder} from './recorder'; | ||
| import {AggregationData, AggregationType, Measure, Measurement, StatsExemplar, View} from './types'; | ||
|
|
||
| const RECORD_SEPARATOR = String.fromCharCode(30); | ||
|
|
||
| /** Implementation for the Base View class. */ |
There was a problem hiding this comment.
Could this comment be more descriptive in terms of the role that BaseView plays?
There was a problem hiding this comment.
Done in be531ae. Thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.