Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Add MetricOptions to simplify all addXGauge #458

Merged

Conversation

mayurkale22
Copy link
Member

The list of options are too long for Gauges (Cumulative metrics - in the future) metrics and most of them are optional. It makes sense to use MetricOptions type to maintain the options. Also, in the future will be adding resource information to the MetricOptions list. This way it is easier to shrink or expand the input options.

Although, this is a breaking change in existing Gauge API but we don't expect too many users using this (released in last version - 0.0.9).

Specs: https://github.com/census-instrumentation/opencensus-specs/pull/248/files

@codecov-io
Copy link

Codecov Report

Merging #458 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   94.63%   94.69%   +0.06%     
==========================================
  Files         150      150              
  Lines        9628     9739     +111     
  Branches      722      727       +5     
==========================================
+ Hits         9111     9222     +111     
  Misses        517      517
Impacted Files Coverage Δ
test/test-instana.ts 53.84% <0%> (-34.62%) ⬇️
src/common-utils.ts 95.83% <0%> (-4.17%) ⬇️
src/tracecontext-format.ts 96.07% <0%> (-0.36%) ⬇️
test/test-tracecontext-format.ts 98.91% <0%> (-0.16%) ⬇️
src/grpc-stats/server-stats.ts 100% <0%> (ø) ⬆️
src/grpc-stats/client-stats.ts 100% <0%> (ø) ⬆️
src/metrics/metric-registry.ts 100% <0%> (ø) ⬆️
test/test-prometheus-stats.ts 100% <0%> (ø) ⬆️
src/grpc-stats/stats-common.ts 100% <0%> (ø) ⬆️
test/test-stackdriver-monitoring.ts 95.31% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26eb382...8c83401. Read the comment docs.

@mayurkale22 mayurkale22 merged commit cbd1d99 into census-instrumentation:master Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants