This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add MetricOptions to simplify all addXGauge #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of options are too long for
Gauges
(Cumulative
metrics - in the future) metrics and most of them are optional. It makes sense to useMetricOptions
type to maintain the options. Also, in the future will be addingresource
information to theMetricOptions
list. This way it is easier to shrink or expand the input options.Although, this is a breaking change in existing
Gauge
API but we don't expect too many users using this (released in last version -0.0.9
).Specs: https://github.com/census-instrumentation/opencensus-specs/pull/248/files