Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix: createScopedRequired depcreated in google-auth-library 3.0.0 #467

Conversation

mayurkale22
Copy link
Member

Fixes #429

DeprecationWarning: The createScopedRequired method on the JWT class has been deprecated, and will be removed in the 3.0 release of google-auth-library.

These changes have all been tested locally and been confirmed to be working.

@mayurkale22
Copy link
Member Author

/cc @diiiego83

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #467 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   94.66%   94.65%   -0.01%     
==========================================
  Files         150      150              
  Lines        9705     9657      -48     
  Branches      734      717      -17     
==========================================
- Hits         9187     9141      -46     
+ Misses        518      516       -2
Impacted Files Coverage Δ
test/test-tracecontext-format.ts 95.45% <0%> (-3.62%) ⬇️
src/stackdriver-monitoring.ts 78.65% <0%> (-1.56%) ⬇️
src/tracecontext-format.ts 95% <0%> (-1.43%) ⬇️
src/binary-format.ts 100% <0%> (ø) ⬆️
test/test-prometheus-stats.ts 100% <0%> (ø) ⬆️
src/validators.ts 100% <0%> (ø) ⬆️
src/stackdriver-cloudtrace.ts 93.33% <0%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ad77d...57990ed. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these code paths already covered by tests? If not, would it make sense to add any new ones?

@jinmel
Copy link
Contributor

jinmel commented Apr 5, 2019

what is blocking this from merge?

@mayurkale22
Copy link
Member Author

Are these code paths already covered by tests? If not, would it make sense to add any new ones?

Yes this is already covered by tests.

@mayurkale22 mayurkale22 merged commit 9632157 into census-instrumentation:master Apr 5, 2019
@mayurkale22 mayurkale22 deleted the remove_createScopedRequired branch April 5, 2019 03:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants