Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Fix README badge URLs #509

Merged

Conversation

irnnr
Copy link
Contributor

@irnnr irnnr commented May 8, 2019

URLs for README badges related to required Node.js version and npm package site were pointing to the Prometheus exporter. This changes the URLs to point to the correct package.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@irnnr
Copy link
Contributor Author

irnnr commented May 8, 2019

update: Signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 8, 2019
@codecov-io
Copy link

codecov-io commented May 8, 2019

Codecov Report

Merging #509 into master will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
+ Coverage   94.61%   94.93%   +0.32%     
==========================================
  Files         145      145              
  Lines       10172    10074      -98     
  Branches      883      883              
==========================================
- Hits         9624     9564      -60     
+ Misses        548      510      -38
Impacted Files Coverage Δ
test/test-instana.ts 61.11% <0%> (-24.08%) ⬇️
src/common-utils.ts 95.83% <0%> (-0.84%) ⬇️
test/test-ioredis.ts 97.16% <0%> (-0.55%) ⬇️
src/binary-format.ts 100% <0%> (ø) ⬆️
src/grpc-stats/client-stats.ts 100% <0%> (ø) ⬆️
src/grpc-stats/common-distributions.ts 100% <0%> (ø) ⬆️
src/grpc-stats/stats-common.ts 100% <0%> (ø) ⬆️
src/validators.ts 100% <0%> (ø) ⬆️
test/test-detect-resource.ts 99.51% <0%> (+0.37%) ⬆️
test/test-jaeger-format.ts 97.18% <0%> (+1.79%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369127b...852771f. Read the comment docs.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@mayurkale22 mayurkale22 merged commit 49ef54f into census-instrumentation:master May 8, 2019
@irnnr irnnr deleted the incorrect-npm-badge-url branch May 8, 2019 23:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants