Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Chore: upgrade engines field to >=8 #533

Merged

Conversation

mayurkale22
Copy link
Member

We have already deprecated Node 6 support #511.

@codecov-io
Copy link

Codecov Report

Merging #533 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #533      +/-   ##
==========================================
+ Coverage   95.28%   95.28%   +<.01%     
==========================================
  Files         146      147       +1     
  Lines        9789     9877      +88     
  Branches      537      542       +5     
==========================================
+ Hits         9327     9411      +84     
- Misses        462      466       +4
Impacted Files Coverage Δ
src/detect-resource.ts 90.9% <0%> (-9.1%) ⬇️
test/test-jaeger-format.ts 94.91% <0%> (-1.24%) ⬇️
test/test-detect-resource.ts 99.02% <0%> (-0.98%) ⬇️
src/http-stats.ts 100% <0%> (ø) ⬆️
src/binary-format.ts 100% <0%> (ø) ⬆️
src/grpc-stats/server-stats.ts 100% <0%> (ø) ⬆️
src/resource-labels.ts 100% <0%> (ø) ⬆️
src/grpc-stats/client-stats.ts 100% <0%> (ø) ⬆️
src/grpc-stats/stats-common.ts 100% <0%> (ø) ⬆️
src/grpc-stats/common-distributions.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e144d4...7140382. Read the comment docs.

@mayurkale22 mayurkale22 merged commit 4a6c3f1 into census-instrumentation:master May 17, 2019
@mayurkale22 mayurkale22 deleted the upgrade_engine branch May 17, 2019 00:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants