This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add support for Summary type and value. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
summary
branch
2 times, most recently
from
c492e59
to
7dc940f
Compare
songy23
approved these changes
Sep 17, 2018
g-easy
reviewed
Sep 17, 2018
| // percentiles directly. | ||
| // | ||
| // See also: https://prometheus.io/docs/concepts/metric_types/#summary | ||
| // A summary value. |
There was a problem hiding this comment.
Maybe worth repeating here that it's not recommended.
|
|
||
| // The start_timestamp only applies to the count and sum in the SummaryValue. | ||
| message SummaryValue { | ||
| // The total number of recorded values from the beginning. Optional since |
There was a problem hiding this comment.
from the beginning -> since start_time
g-easy
reviewed
Sep 17, 2018
| google.protobuf.UInt64Value count = 1; | ||
|
|
||
| // The sum of values in the snapshot. Optional since some systems don't | ||
| // expose this. If count is zero then this field must be zero or not set |
There was a problem hiding this comment.
How about "This field must be unset if the sum is not available."
|
|
||
| message Quantile { | ||
| // Must be in the interval (0.0, 1.0] | ||
| required double quantile = 1; |
There was a problem hiding this comment.
Remove "required" this is proto3 ;)
| } | ||
| } | ||
|
|
||
| // Values calculated from over a sliding time window. |
There was a problem hiding this comment.
How about "Values calculated over an arbitrary time window."
bogdandrutu
force-pushed
the
summary
branch
from
7dc940f
to
0ca2a0e
Compare
rghetia
reviewed
Sep 18, 2018
| // (usually things like request durations and response sizes). While it | ||
| // also provides a total count of observations and a sum of all observed | ||
| // values, it calculates configurable quantiles over a sliding time window. | ||
| // This is not recommended, since cannot be aggregated. |
There was a problem hiding this comment.
nit: s/since cannot/since it cannot/
| // percentiles directly. | ||
| // | ||
| // See also: https://prometheus.io/docs/concepts/metric_types/#summary | ||
| // A summary value. This is not recommended, since cannot be aggregated. |
g-easy
approved these changes
Sep 18, 2018
| @@ -91,6 +92,13 @@ message MetricDescriptor { | |||
| // Distribution cumulative measurement. The count can only go up, if resets | |||
| // then the start_time should also be reset. | |||
| CUMULATIVE_DISTRIBUTION = 5; | |||
|
|
|||
| // Old libraries implemented Histograms as a summary samples observations | |||
There was a problem hiding this comment.
as a summary samples observations -> as a summary of observations? measurements?
| @@ -91,6 +92,13 @@ message MetricDescriptor { | |||
| // Distribution cumulative measurement. The count can only go up, if resets | |||
| // then the start_time should also be reset. | |||
| CUMULATIVE_DISTRIBUTION = 5; | |||
|
|
|||
| // Old libraries implemented Histograms as a summary samples observations | |||
There was a problem hiding this comment.
Old libraries implemented -> some frameworks implement ?
bogdandrutu
force-pushed
the
summary
branch
from
0ca2a0e
to
1673321
Compare
g-easy
approved these changes
Sep 18, 2018
mayurkale22
reviewed
Sep 19, 2018
| // also provides a total count of observations and a sum of all observed | ||
| // values, it calculates configurable quantiles over a sliding time window. | ||
| // This is not recommended, since it cannot be aggregated. | ||
| SUMMARY = 7; |
There was a problem hiding this comment.
I think this should be number 6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value better supports dropwizard histograms.