Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger.exception error when no exception present in Azure log exporter #1006

Merged
merged 3 commits into from
Jan 27, 2021
Merged

Fix logger.exception error when no exception present in Azure log exporter #1006

merged 3 commits into from
Jan 27, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jan 27, 2021

Fixes #1005

@google-cla google-cla bot added the cla: yes label Jan 27, 2021
hectorhdzg
hectorhdzg approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit ec72cd3 into census-instrumentation:master Jan 27, 2021
@lzchen lzchen deleted the fix branch January 27, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@aabmass aabmass Awaiting requested review from aabmass aabmass is a code owner

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it expected when using logger.error or logger.exception, the messages are treated as trace?
2 participants
@lzchen @hectorhdzg