Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds str fallback to envelope serialization #1196

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Adds str fallback to envelope serialization #1196

merged 2 commits into from
Mar 16, 2023

Commits on Mar 13, 2023

  1. Adds str fallback to envelope serialization 

    When serialization fails (e.g. when a non-JSON-serializable value is added to the properties) the entire batch that envelope belongs to does not get sent. Falling back to to str as a means of serialization when JSON serialization fails seems like a sane default that greatly reduces the risk of missed telemetry.
    @ddeschepper
    ddeschepper committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    99f616e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Update changelog

    @ddeschepper
    ddeschepper committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    7a99b2d View commit details
    Browse the repository at this point in the history