Update gRPC span names to match spec #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Apr 10, 2018
| def _get_span_name(client_call_details): | ||
| """Generates a span name based off of the gRPC client call details""" | ||
| method_name = client_call_details.method[1:].replace('/', '.') | ||
| return '{}.{}'.format(SENT_PREFIX, method_name) |
There was a problem hiding this comment.
FYI: The prefix (sent, recv) will be replaced by the Span.Kind (https://github.com/census-instrumentation/opencensus-proto/blob/master/opencensus/proto/trace/trace.proto#L66).
In SD exporter we will still attach the prefixes, but in Jagger and Zipkin we will just set the kind.
Here census-instrumentation/opencensus-specs#85 (not documented) but the issue is about that.
There was a problem hiding this comment.
Acknowledged, thanks!
liyanhui1228
approved these changes
Apr 10, 2018
kcooperstein
pushed a commit
to kcooperstein/opencensus-python
that referenced
this pull request
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.