Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the should_sample logic for tracer #166

Merged
merged 6 commits into from
Apr 25, 2018
Merged

Update the should_sample logic for tracer #166

merged 6 commits into from
Apr 25, 2018

Conversation

liyanhui1228
Copy link
Contributor

Fixes #159

wkiser
wkiser reviewed Apr 24, 2018
View reviewed changes
Copy link
Contributor

@wkiser wkiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the span context in the case where a span is sampled? That way child spans get the sampled/enabled bit set in the span context.

opencensus/trace/tracer.py
@@ -74,7 +74,7 @@ def should_sample(self):
:returns: Whether to trace the request or not.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the docstring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@liyanhui1228 liyanhui1228 merged commit fbbe9c5 into census-instrumentation:master Apr 25, 2018
@liyanhui1228 liyanhui1228 deleted the sampling branch April 25, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wkiser wkiser wkiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@liyanhui1228 @wkiser