Add streaming support and message events to gRPC interceptors #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyanhui1228
reviewed
May 4, 2018
| def _start_server_span(self, rpc_request_info): | ||
| metadata = rpc_request_info.context.invocation_metadata() | ||
| def intercept_service(self, continuation, handler_call_details): | ||
| def latency_wrapper(behavior, request_streaming, response_streaming): |
There was a problem hiding this comment.
Does this name need to be the same as the grpc example? Probably change to trace_wrapper?
|
@liyanhui1228, any idea whats wrong with the most recent circleci checks? |
liyanhui1228
approved these changes
May 7, 2018
|
@wkiser System tests are flaky sometimes, rebuilding it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback based util being used before didn't work very well for streams. Refactoring based off of the example in grpc/grpc#14306.