Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the 0.19 version of google-cloud-trace #174

Merged
merged 1 commit into from
May 10, 2018
Merged

Support the 0.19 version of google-cloud-trace #174

merged 1 commit into from
May 10, 2018

Conversation

brianquinlan
Copy link
Contributor

google-cloud-trace is at version 0.19.0:
https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/trace/setup.py

We should support that version to prevent errors when installing google-cloud-trace and opencensus i.e.
$ pip install google-cloud-trace opencensus
...
opencensus 0.1.4 has requirement google-cloud-trace<0.18dev,>=0.17.0, but you'll have google-cloud-trace 0.19.0 which is incompatible.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@brianquinlan
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@liyanhui1228 liyanhui1228 merged commit 604343c into census-instrumentation:master May 10, 2018
@brianquinlan brianquinlan deleted the patch-1 branch May 10, 2018 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants