Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Remove min and max from Distribution. #501

Merged
merged 4 commits into from Feb 12, 2019

Conversation

songy23
Copy link
Contributor

@songy23 songy23 commented Feb 12, 2019

Fixes #411.

min and max have been removed from Distribution in all other languages.

@@ -1,4 +1,5 @@
# Copyright 2018, OpenCensus Authors
# Copyright 2018, OpenCensus Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, seems to be a bad copy-and-paste.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides one typo.

@songy23 songy23 merged commit 6c472df into census-instrumentation:master Feb 12, 2019
@songy23 songy23 deleted the distribution branch February 12, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants